-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to src based repository structure #2459
Conversation
But actually the changes are very small, so maybe not that large of an issue |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2459 +/- ##
==========================================
- Coverage 92.52% 92.52% -0.01%
==========================================
Files 234 234
Lines 20006 20005 -1
==========================================
- Hits 18511 18510 -1
Misses 1495 1495 ☔ View full report in Codecov by Sentry. |
1804862
to
78df540
Compare
40859eb
to
1a12381
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a changelog, and I don't feel able to review the dark magic in setup.cfg
, otherwise it looks fine
See setuptools documentation: https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#package-discovery-and-namespace-packages |
4b0f5a7
to
4ff34d7
Compare
Immediate issue:
Since all files were moved, they were all "touched" in this PR, which triggered the pre-commit hook to reformat all files.
So they are not just moved but also reformatted.