David mts #279

davidsudm · 2019-10-15T15:13:57Z

No description provided.

…tic TLS' during test_cone_simu.py

…for raw histogram to 4097.

…imtel

…ysis # Conflicts: # digicampipe/io/event_stream.py # digicampipe/scripts/mpe.py # digicampipe/scripts/pulse_template.py # digicampipe/scripts/raw.py # digicampipe/scripts/timing.py # digicampipe/scripts/view.py

Explain "magic" smoothing factor

pep8speaks · 2019-10-15T15:14:10Z

Hello @davidsudm! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file digicampipe/calib/trigger.py:

Line 230:12: E127 continuation line over-indented for visual indent

In the file digicampipe/instrument/light_source.py:

Line 297:80: E501 line too long (84 > 79 characters)
Line 298:80: E501 line too long (86 > 79 characters)

In the file digicampipe/instrument/optics.py:

Line 26:9: E265 block comment should start with '# '
Line 27:9: E265 block comment should start with '# '
Line 28:9: E265 block comment should start with '# '
Line 29:9: E265 block comment should start with '# '
Line 30:9: E265 block comment should start with '# '
Line 94:30: E128 continuation line under-indented for visual indent
Line 95:30: E128 continuation line under-indented for visual indent
Line 96:30: E128 continuation line under-indented for visual indent
Line 97:30: E128 continuation line under-indented for visual indent
Line 106:20: E127 continuation line over-indented for visual indent
Line 112:19: E127 continuation line over-indented for visual indent
Line 112:80: E501 line too long (80 > 79 characters)
Line 114:80: E501 line too long (148 > 79 characters)
Line 116:80: E501 line too long (125 > 79 characters)
Line 117:80: E501 line too long (114 > 79 characters)
Line 121:80: E501 line too long (112 > 79 characters)
Line 145:80: E501 line too long (87 > 79 characters)
Line 157:42: E202 whitespace before ')'
Line 158:42: W605 invalid escape sequence '\e'

In the file digicampipe/io/event_stream.py:

Line 95:80: E501 line too long (104 > 79 characters)
Line 108:80: E501 line too long (114 > 79 characters)
Line 112:80: E501 line too long (95 > 79 characters)

In the file digicampipe/scripts/charge_linearity.py:

Line 6:80: E501 line too long (118 > 79 characters)
Line 46:80: E501 line too long (86 > 79 characters)
Line 125:1: W293 blank line contains whitespace
Line 219:80: E203 whitespace before ','
Line 228:80: E203 whitespace before ','

In the file digicampipe/scripts/charge_resolution.py:

Line 38:80: E501 line too long (99 > 79 characters)
Line 112:80: E501 line too long (86 > 79 characters)
Line 117:80: E501 line too long (91 > 79 characters)
Line 118:80: E501 line too long (86 > 79 characters)
Line 119:80: E501 line too long (81 > 79 characters)

In the file digicampipe/scripts/fmpe.py:

Line 80:58: W605 invalid escape sequence '\c'
Line 81:51: W605 invalid escape sequence '\s'
Line 81:67: W605 invalid escape sequence '\c'
Line 82:51: W605 invalid escape sequence '\s'
Line 82:67: W605 invalid escape sequence '\c'
Line 85:50: W605 invalid escape sequence '\c'
Line 85:80: E501 line too long (81 > 79 characters)
Line 86:43: W605 invalid escape sequence '\s'
Line 86:59: W605 invalid escape sequence '\c'
Line 88:43: W605 invalid escape sequence '\s'
Line 88:59: W605 invalid escape sequence '\c'

In the file digicampipe/scripts/mpe.py:

Line 6:80: E501 line too long (162 > 79 characters)
Line 7:80: E501 line too long (123 > 79 characters)
Line 8:80: E501 line too long (121 > 79 characters)
Line 83:80: E501 line too long (80 > 79 characters)
Line 173:80: E501 line too long (94 > 79 characters)
Line 357:35: E128 continuation line under-indented for visual indent
Line 358:35: E128 continuation line under-indented for visual indent
Line 506:13: E265 block comment should start with '# '

In the file digicampipe/scripts/mts_analysis.py:

Line 8:80: E501 line too long (101 > 79 characters)
Line 10:80: E501 line too long (103 > 79 characters)
Line 45:80: E501 line too long (118 > 79 characters)
Line 49:80: E501 line too long (90 > 79 characters)
Line 52:5: E303 too many blank lines (2)
Line 68:80: E501 line too long (150 > 79 characters)
Line 70:80: E501 line too long (81 > 79 characters)
Line 72:80: E501 line too long (88 > 79 characters)
Line 73:80: E501 line too long (88 > 79 characters)
Line 74:80: E501 line too long (88 > 79 characters)
Line 103:5: E303 too many blank lines (2)
Line 116:80: E501 line too long (83 > 79 characters)
Line 123:5: E303 too many blank lines (3)
Line 132:80: E501 line too long (82 > 79 characters)
Line 152:12: W292 no newline at end of file

In the file digicampipe/scripts/mts_fast_feedback.py:

Line 4:80: E501 line too long (112 > 79 characters)
Line 6:80: E501 line too long (118 > 79 characters)
Line 27:1: E305 expected 2 blank lines after class or function definition, found 1
Line 30:5: E303 too many blank lines (2)
Line 59:5: E303 too many blank lines (2)
Line 63:80: E501 line too long (101 > 79 characters)
Line 70:5: E303 too many blank lines (2)
Line 71:80: E501 line too long (94 > 79 characters)
Line 72:80: E501 line too long (94 > 79 characters)
Line 73:80: E501 line too long (94 > 79 characters)
Line 74:80: E501 line too long (94 > 79 characters)
Line 76:80: E501 line too long (94 > 79 characters)
Line 86:80: E501 line too long (84 > 79 characters)
Line 87:80: E501 line too long (90 > 79 characters)
Line 88:80: E501 line too long (95 > 79 characters)
Line 89:80: E501 line too long (96 > 79 characters)
Line 91:13: E265 block comment should start with '# '
Line 99:80: E501 line too long (122 > 79 characters)
Line 108:17: E265 block comment should start with '# '
Line 116:80: E501 line too long (138 > 79 characters)
Line 124:17: E265 block comment should start with '# '
Line 132:80: E501 line too long (122 > 79 characters)
Line 141:80: E501 line too long (112 > 79 characters)
Line 142:80: E501 line too long (92 > 79 characters)
Line 147:48: E128 continuation line under-indented for visual indent
Line 147:80: E501 line too long (112 > 79 characters)
Line 148:80: E501 line too long (92 > 79 characters)
Line 153:48: E128 continuation line under-indented for visual indent
Line 153:80: E501 line too long (112 > 79 characters)
Line 154:80: E501 line too long (92 > 79 characters)
Line 159:48: E128 continuation line under-indented for visual indent
Line 159:80: E501 line too long (112 > 79 characters)
Line 160:80: E501 line too long (92 > 79 characters)
Line 165:48: E128 continuation line under-indented for visual indent
Line 165:80: E501 line too long (112 > 79 characters)
Line 166:80: E501 line too long (92 > 79 characters)
Line 171:48: E128 continuation line under-indented for visual indent
Line 171:80: E501 line too long (112 > 79 characters)
Line 172:80: E501 line too long (92 > 79 characters)
Line 177:48: E128 continuation line under-indented for visual indent
Line 177:80: E501 line too long (112 > 79 characters)
Line 178:80: E501 line too long (92 > 79 characters)
Line 183:13: E265 block comment should start with '# '
Line 183:13: E303 too many blank lines (2)
Line 185:80: E501 line too long (162 > 79 characters)
Line 191:1: W391 blank line at end of file

In the file digicampipe/scripts/raw.py:

Line 28:80: E501 line too long (112 > 79 characters)
Line 45:80: E501 line too long (100 > 79 characters)

In the file digicampipe/tests/test_ac_led.py:

Line 8:80: E501 line too long (80 > 79 characters)

In the file digicampipe/tests/test_calibration_container.py:

Line 47:1: E302 expected 2 blank lines, found 1
Line 51:80: E501 line too long (100 > 79 characters)
Line 64:1: W391 blank line at end of file

In the file digicampipe/utils/fitter.py:

Line 16:51: W605 invalid escape sequence '\s'
Line 17:51: W605 invalid escape sequence '\s'
Line 36:80: E501 line too long (111 > 79 characters)
Line 43:80: E501 line too long (81 > 79 characters)
Line 206:51: W605 invalid escape sequence '\s'
Line 207:51: W605 invalid escape sequence '\s'
Line 223:51: W605 invalid escape sequence '\s'
Line 224:51: W605 invalid escape sequence '\s'
Line 258:46: W605 invalid escape sequence '\m'
Line 258:64: W605 invalid escape sequence '\m'
Line 261:51: W605 invalid escape sequence '\s'
Line 262:51: W605 invalid escape sequence '\s'
Line 338:80: E501 line too long (81 > 79 characters)
Line 339:13: E128 continuation line under-indented for visual indent
Line 356:49: W605 invalid escape sequence '\m'
Line 358:51: W605 invalid escape sequence '\s'
Line 359:51: W605 invalid escape sequence '\s'
Line 360:46: W605 invalid escape sequence '\m'
Line 365:80: E501 line too long (92 > 79 characters)
Line 417:80: E501 line too long (110 > 79 characters)

In the file digicampipe/utils/pdf.py:

Line 74:80: E501 line too long (80 > 79 characters)

In the file digicampipe/utils/pulse_template.py:

Line 44:80: E501 line too long (132 > 79 characters)
Line 45:80: E501 line too long (110 > 79 characters)
Line 62:80: E501 line too long (86 > 79 characters)

Comment last updated at 2019-10-17 09:28:14 UTC

…bined

calispac added 30 commits October 29, 2018 14:23

charge linearity and resolution as cli scripts

419b0db

fixed scale correction for p.e.

dfcdd82

charge linearity and resolution as cli scripts

945baa7

saving waveform std

3c7858b

remove check if output file exists

deaeeb5

adding nsb_computation from baseline std

c4a4516

compute waveform std

88a05e8

take similar indices for baseline and dark charge

06814dd

pep8

b82d536

fmpe plot also plot baseline distribution

b92b152

use matplotlibrc file

5d5a010

renamed charge method and docstring

f041fbc

pep8

3846bab

use matplotlibrc file

f7efc07

cleanup and choose integration method

79403c9

adding shift option

89e1ab1

use matplotlibrc file

8f003ed

use matplotlibrc file

e98f061

function renaming

7093c9a

saving results to fits table

f898b72

saving results to fits file

3667399

saving results to fits file

c09773d

input files for --display changed

bce2ac4

removed commented stuff

1ea9193

update histogram version

7c55caa

abstractclassmethod deprecated since py3.3.

5464218

testing and improvement for LightSource

4b714db

fixes and tests for ACLED

f071a67

cleanup

4b4df48

Merge remote-tracking branch 'origin/master' into charge_resolution

1c77956

calispac and others added 28 commits February 28, 2019 10:24

adding a test

151a7c4

typos

99ae994

remove baseline before computation

7e8adf1

cleanup

7064ee4

try to fix 'ImportError: dlopen: cannot load any more object with sta…

2a4aa8f

…tic TLS' during test_cone_simu.py

pep8

d0ab6c3

pep8

7084ee8

try to fix 'ImportError: dlopen: cannot load any more object with sta…

8120e9a

…tic TLS' during test_cone_simu.py

test triggered from travis website execute all tests

97f5c7b

try to fix 'ImportError: dlopen: cannot load any more object with sta…

6d22faf

…tic TLS' during test_cone_simu.py

try to fix 'ImportError: dlopen: cannot load any more object with sta…

b8207c6

…tic TLS' during test_cone_simu.py

update viewer to deal with tels_with_data beeing a set

35e19cd

adding depedency for eventio

2b4c196

add integral order into template

adac496

Merge remote-tracking branch 'origin/master' into charge_resolution

6520d09

add instrument info for simtel files

b7d999e

adding option to selected sub samples for waveform, extend bin edges …

f4bdc00

…for raw histogram to 4097.

updating the simtel bash scripts

f4bbeb6

adding option to selected sub samples for waveform, extend bin edges …

5d93ea1

…for raw histogram to 4097.

creating module for optical elements

5b5a0cb

fixing bugs in event_stream

098fc4e

fixing bugs in simtel reader

536b76a

default mpe fitter

cb5e542

Merge remote-tracking branch 'origin/pipeline-simtel' into pipeline-s…

a118869

…imtel

Merge remote-tracking branch 'origin/charge_resolution' into mts_anal…

0570226

…ysis # Conflicts: # digicampipe/io/event_stream.py # digicampipe/scripts/mpe.py # digicampipe/scripts/pulse_template.py # digicampipe/scripts/raw.py # digicampipe/scripts/timing.py # digicampipe/scripts/view.py

initialize_fit works now with customize bin_width

59bdb81

Explain "magic" smoothing factor

update before repairing

e5554c6

update before repairing

70ec001

fix pixel list indexing that leads to trouble in the option --fit com…

b9d762f

…bined

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

David mts #279

David mts #279

davidsudm commented Oct 15, 2019

pep8speaks commented Oct 15, 2019 •

edited

Loading

David mts #279

Are you sure you want to change the base?

David mts #279

Conversation

davidsudm commented Oct 15, 2019

pep8speaks commented Oct 15, 2019 • edited Loading

Comment last updated at 2019-10-17 09:28:14 UTC

pep8speaks commented Oct 15, 2019 •

edited

Loading