Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative produce data (issue #16) #17

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

dneise
Copy link

@dneise dneise commented Apr 9, 2018

Here I show an alternative "produce_data.py". Details about this and why I did what I did, I have explained in issue #16. If there are questions about the "why" then maybe we can discuss them in that issue?

Technical questions and comments regarding the code, should definitely still go here.

@pep8speaks
Copy link

pep8speaks commented Apr 9, 2018

Hello @dneise! Thanks for updating the PR.

Line 37:1: E302 expected 2 blank lines, found 1
Line 44:43: E261 at least two spaces before inline comment
Line 44:44: E262 inline comment should start with '# '
Line 44:80: E501 line too long (92 > 79 characters)
Line 287:30: E127 continuation line over-indented for visual indent
Line 308:26: E127 continuation line over-indented for visual indent
Line 312:16: E127 continuation line over-indented for visual indent
Line 340:80: E501 line too long (100 > 79 characters)
Line 341:80: E501 line too long (108 > 79 characters)
Line 342:80: E501 line too long (118 > 79 characters)
Line 349:80: E501 line too long (97 > 79 characters)
Line 350:80: E501 line too long (95 > 79 characters)
Line 353:80: E501 line too long (84 > 79 characters)
Line 354:80: E501 line too long (118 > 79 characters)
Line 356:80: E501 line too long (81 > 79 characters)
Line 362:80: E501 line too long (99 > 79 characters)
Line 364:80: E501 line too long (115 > 79 characters)
Line 366:80: E501 line too long (90 > 79 characters)
Line 372:80: E501 line too long (149 > 79 characters)
Line 373:80: E501 line too long (113 > 79 characters)
Line 375:80: E501 line too long (95 > 79 characters)
Line 382:80: E501 line too long (100 > 79 characters)
Line 394:80: E501 line too long (93 > 79 characters)
Line 410:80: E501 line too long (91 > 79 characters)
Line 411:80: E501 line too long (81 > 79 characters)
Line 436:80: E501 line too long (85 > 79 characters)
Line 439:80: E501 line too long (98 > 79 characters)
Line 445:80: E501 line too long (118 > 79 characters)
Line 471:80: E501 line too long (168 > 79 characters)
Line 473:80: E501 line too long (110 > 79 characters)
Line 480:80: E501 line too long (97 > 79 characters)
Line 489:80: E501 line too long (84 > 79 characters)
Line 492:80: E501 line too long (80 > 79 characters)
Line 501:80: E501 line too long (95 > 79 characters)
Line 509:80: E501 line too long (82 > 79 characters)
Line 534:80: E501 line too long (91 > 79 characters)
Line 535:80: E501 line too long (95 > 79 characters)
Line 545:80: E501 line too long (100 > 79 characters)
Line 553:80: E501 line too long (82 > 79 characters)
Line 563:80: E501 line too long (94 > 79 characters)
Line 589:80: E501 line too long (111 > 79 characters)
Line 597:80: E501 line too long (82 > 79 characters)
Line 607:80: E501 line too long (85 > 79 characters)
Line 612:80: E501 line too long (86 > 79 characters)
Line 619:80: E501 line too long (86 > 79 characters)
Line 621:80: E501 line too long (82 > 79 characters)
Line 628:80: E501 line too long (117 > 79 characters)
Line 633:80: E501 line too long (105 > 79 characters)
Line 648:80: E501 line too long (119 > 79 characters)
Line 655:80: E501 line too long (117 > 79 characters)
Line 659:80: E501 line too long (113 > 79 characters)
Line 663:80: E501 line too long (82 > 79 characters)
Line 673:80: E501 line too long (96 > 79 characters)
Line 676:80: E501 line too long (112 > 79 characters)
Line 678:80: E501 line too long (90 > 79 characters)
Line 680:80: E501 line too long (90 > 79 characters)
Line 694:80: E501 line too long (105 > 79 characters)
Line 695:80: E501 line too long (117 > 79 characters)

Line 6:80: E501 line too long (96 > 79 characters)
Line 13:5: E265 block comment should start with '# '
Line 29:5: E265 block comment should start with '# '
Line 45:80: E501 line too long (86 > 79 characters)
Line 63:80: E501 line too long (130 > 79 characters)
Line 75:52: E225 missing whitespace around operator
Line 75:80: E501 line too long (84 > 79 characters)
Line 76:39: E225 missing whitespace around operator
Line 77:46: E225 missing whitespace around operator
Line 77:80: E501 line too long (90 > 79 characters)

Comment last updated on April 09, 2018 at 07:33 Hours UTC

@dneise dneise requested a review from calispac April 9, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants