This repository was archived by the owner on Feb 8, 2022. It is now read-only.
use Nerdbank.GitVersioning #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI build failed with: |
|
By default without a version.json, it produced: //------------------------------------------------------------------------------
// <auto-generated>
// This code was generated by a tool.
// Runtime Version:4.0.30319.42000
//
// Changes to this file may cause incorrect behavior and will be lost if
// the code is regenerated.
// </auto-generated>
//------------------------------------------------------------------------------
namespace Froto.Parser
[<assembly: System.Reflection.AssemblyVersionAttribute("0.0.0.0")>]
[<assembly: System.Reflection.AssemblyFileVersionAttribute("0.0.125.43072")>]
[<assembly: System.Reflection.AssemblyInformationalVersionAttribute("0.0.125+40a86c726a")>]
do()
[<System.CodeDom.Compiler.GeneratedCode("Nerdbank.GitVersioning.Tasks","2.3.136.25003")>]
type internal ThisAssembly() =
static member internal AssemblyVersion = "0.0.0.0"
static member internal AssemblyFileVersion = "0.0.125.43072"
static member internal AssemblyInformationalVersion = "0.0.125+40a86c726a"
static member internal AssemblyName = "Froto.Parser"
static member internal AssemblyTitle = "Froto.Parser"
static member internal AssemblyConfiguration = "Debug"
static member internal GitCommitId = "40a86c726a95abca52dd1fece35727c497f6b86a"
static member internal RootNamespace = "Froto.Parser"
do()It did not conflict with: // <auto-generated>
// Generated by the FSharp WriteCodeFragment class.
// </auto-generated>
namespace FSharp
open System
open System.Reflection
[<assembly: System.Reflection.AssemblyCompanyAttribute("Cameron Taggart, James Hugard")>]
[<assembly: System.Reflection.AssemblyConfigurationAttribute("Debug")>]
[<assembly: System.Reflection.AssemblyDescriptionAttribute("A parser for .proto files for Protocol Buffers.")>]
[<assembly: System.Reflection.AssemblyProductAttribute("Froto.Parser")>]
[<assembly: System.Reflection.AssemblyTitleAttribute("Froto.Parser")>]
do() |
This reverts commit 40a86c7.
ctaggart
commented
Mar 19, 2019
| script: | ||
| - dotnet restore Froto.unix.sln | ||
| - dotnet build Froto.unix.sln -c Release | ||
| - git fetch --unshallow |
There was a problem hiding this comment.
This is needed for Travis CI
ctaggart
commented
Mar 19, 2019
Compiler/Froto.Compiler.fsproj
Outdated
| @@ -27,5 +27,6 @@ | |||
| <PackageReference Update="FSharp.Core" Version="4.5.2" /> | |||
| <PackageReference Include="Argu" Version="4.0.0" /> | |||
| <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-*" PrivateAssets="All" /> | |||
| <!-- <PackageReference Include="Nerdbank.GitVersioning" Version="2.3.136" /> --> | |||
There was a problem hiding this comment.
Nerbankbank.GitVersioning is failing F# exe builds with:
C:\projects\froto\Compiler\Program.fs(20,5): error FS0433: A function labeled with the 'EntryPointAttribute' attribute must be the last declaration in the last file in the compilation sequence. [C:\projects\froto\Compiler\Froto.Compiler.fsproj]
There was a problem hiding this comment.
ctaggart
commented
Mar 19, 2019
| @@ -1060,6 +1060,7 @@ module RegressionTests = | |||
|
|
|||
| [<Fact>] | |||
| let ``proto3 oneof type doesn't parse (#88)`` () = | |||
| System.Diagnostics.Debugger.Break() | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revising the build system to use versioning from https://github.com/AArnott/Nerdbank.GitVersioning. It is one step closer to being fully deterministic so that you can build the same package locally, on AppVeyor, on Travis CI, on Azure Pipelines, or any other CI and get the same bytes. For convenience, the prelease versions are simply the git commit short and match
git rev-parse --short HEADas well as what GitHub shows.@7sharp9, you should be able to run
./build.ps1and get a nupkg to try out elsewhere.I'm getting libgit2sharp warning when I add this: