Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

add nuget lock #104

Merged
merged 11 commits into from
Mar 29, 2019
Merged

add nuget lock #104

merged 11 commits into from
Mar 29, 2019

Conversation

ctaggart
Copy link
Owner

@ctaggart ctaggart commented Mar 27, 2019

NuGet 4.9 enabled repeatable package restores using a lock file. A sha512 of the content is used so a nuget package returns the same hash before it is signed and after. Unfortunately, the contentHash is giving different results on different platforms. and nuget packages with the same version, but different sdk versions are resulting in different contentHash values.

Working lock files are required to have deterministic builds. I'd really like to see deterministic builds become common in our .NET community. I would also like to see these contributions reviewed and merged:

NuGet: allow creating deterministic packages
NuGet/NuGet.Client#2775

Add support for --pathmap
dotnet/fsharp#5801

add deterministic to msbuild targets
dotnet/fsharp#6363

@ctaggart ctaggart marked this pull request as ready for review March 29, 2019 21:06
@ctaggart
Copy link
Owner Author

This wasn't super easy. A summary is in NuGet/Home#7921 (comment)

@ctaggart ctaggart merged commit 81263c5 into master Mar 29, 2019
@ctaggart ctaggart deleted the lock branch March 29, 2019 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant