Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

process import statements #65

Closed
wants to merge 8 commits into from
Closed

process import statements #65

wants to merge 8 commits into from

Conversation

jhugard
Copy link
Collaborator

@jhugard jhugard commented Oct 15, 2016

Implement #48, Parser Improvements.

This is still a work in progress and the APIs are not yet finalized.

Initial check-in has functional support for import from strings, streams, and files. Further, it supports normal, public, and weak imports.

@jhugard jhugard changed the title [WIP] Parser improvements 48 [WIP] Parser improvements Aug 26, 2017
@ctaggart
Copy link
Owner

It has been a while since this has been touched. Keep it open?

@ctaggart
Copy link
Owner

Feel free to reopen when ready for #48 work.

@ctaggart ctaggart closed this Dec 25, 2017
@ctaggart ctaggart reopened this Sep 29, 2018
@ctaggart ctaggart changed the title [WIP] Parser improvements process import statements Sep 29, 2018
@jhugard jhugard mentioned this pull request Sep 29, 2018
6 tasks
@7sharp9
Copy link
Collaborator

7sharp9 commented Sep 30, 2018

I'll try and check this later next week, I managed to get round import not being processed by using a recursive function when I create types so that imports are processed in hierarchical order by the type lookup map.

@7sharp9
Copy link
Collaborator

7sharp9 commented Sep 30, 2018

Theres also another issue I have in Falanx where I require the type in the proto definition to be in topological order, it would be nice if the parser did this too...

@ctaggart
Copy link
Owner

ctaggart commented Oct 9, 2018

@7sharp9 Let me know if you want this merged in for a 0.7.0.

@7sharp9
Copy link
Collaborator

7sharp9 commented Oct 9, 2018

@ctaggart To be honest Ive not had the time to test it yet.

@7sharp9
Copy link
Collaborator

7sharp9 commented Mar 19, 2019

update: I still really want this honest! Just not had time to try it yet :-(

@ctaggart
Copy link
Owner

I updated build versioning in #101 and merged it in. Hopefully that will make it easier for you to work on. Current failure is a unit test:

Error Message:
 System.IO.FileNotFoundException : riak_kv.proto
Stack Trace:
   at Froto.Parser.Parse.fetchFromFile(IEnumerable`1 dirsList, String filename) in C:\projects\froto\Parser\Parser.fs:line 805
   at Froto.Parser.Parse.loadFromFile(String fileName, IEnumerable`1 dirsList) in C:\projects\froto\Parser\Parser.fs:line 819
   at TestParser.FileImport.Resolve File Import() in C:\projects\froto\Parser.Test\TestParser.fs:line 1334
Total tests: 118. Passed: 117. Failed: 1. Skipped: 0.
Test Run Failed.

@jhugard
Copy link
Collaborator Author

jhugard commented Aug 16, 2019

Closing this in favor of a PR specific to processing import statements.

@jhugard jhugard closed this Aug 16, 2019
@ctaggart
Copy link
Owner

Sounds good. Should we delete the branch?

@jhugard jhugard deleted the parser-improvements-48 branch August 16, 2019 15:30
@jhugard
Copy link
Collaborator Author

jhugard commented Aug 16, 2019

Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants