Merge pull request #531 from NickAllmakerOpsCompass/fix_fileattr

Fixing preserving linux file permissions
cthackers · Aug 18, 2024 · ca54d1a · ca54d1a
2 parents b148463 + 3e2fa32
commit ca54d1a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/headers/entryHeader.js b/headers/entryHeader.js
@@ -183,7 +183,7 @@ module.exports = function () {
 
  // get Unix file permissions
  get fileAttr() {
- return uint16(_attr >> 16) & 0xfff;
+ return (_attr || 0) >> 16 & 0xfff;
  },
 
  get offset() {

diff --git a/test/header.js b/test/header.js
@@ -142,6 +142,16 @@ describe("headers", () => {
  expect(head.toJSON()).to.eql(headerdata);
  });
 
+ it("handles fileAttr when attr above 0x80000000", () => {
+ const attr = 0x81E80000;
+
+ const head = new centralHeader();
+ head.loadFromBinary(readBuf);
+ head.attr = attr;
+
+ expect(head.fileAttr).to.equal(0x01E8);
+ });
+
  it("read binary and create new binary from it, they have to be equal", () => {
  const head = new centralHeader();
  head.loadFromBinary(readBuf);