Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getEntries/getEntry no longer read files in folder on archives created with version >= 0.5.13 #521

Closed
Arkellys opened this issue Jul 21, 2024 · 5 comments

Comments

@Arkellys
Copy link

Arkellys commented Jul 21, 2024

A bug was introduced on version 0.5.13 which affect reading files inside folders. I only tested the methods getEntries() and readFileAsync() (which uses getEntry()), but I suppose this bug does not affect only these two. Here are some test cases:

Whether I test on v0.5.12 or v0.5.13:

  • For an archive created with v0.5.12

    • getEntries() -> returns root files + files in folder, with entryName as: folder/file.jpg
    • getEntry() -> works as expected
  • For an archive created with v0.5.13

    • getEntries() -> returns root files + files in folder, with entryName as: folder\\file.jpg
    • getEntry() -> returns an error (via readFileAsync()): getEntry failed for:folder/file.jpg

Additionnaly, I can see that for both archives all the files and folders are here and with the correct names. Extracting all works as expected.

Something messing up the paths?

--

Versions:

  • Node v20.9.0
  • Windows 10
@Arkellys Arkellys changed the title getEntries/getEntry no longer read files in folder on archive created with version >= 0.5.13 getEntries/getEntry no longer read files in folder on archives created with version >= 0.5.13 Jul 21, 2024
@Arkellys
Copy link
Author

Arkellys commented Jul 21, 2024

I'm not sure the version matches, but maybe it has something to do with the change on this commit (L.299)? It looks like a Windows fix has been removed but is not covered by the new code.

@jcompagner
Copy link

we have the same problem, suddenly the entries that are created i guess on windows are give the \ in the path/name
So suddenly i have to get the entry also by a \ (or compare it my self)
I think this is wrong, all other tools will always use the forward slash.

@5saviahv
Copy link
Collaborator

5saviahv commented Aug 1, 2024

It is related with #497 and #512 and fixed in repo, but it is not released by @cthackers yet.

@cthackers
Copy link
Owner

It's released now!

@Arkellys
Copy link
Author

Arkellys commented Aug 5, 2024

I just tested and this issue is solved with v0.5.15, thank you.

@Arkellys Arkellys closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants