-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getEntries
/getEntry
no longer read files in folder on archives created with version >= 0.5.13
#521
Comments
getEntries
/getEntry
no longer read files in folder on archive created with version >= 0.5.13
getEntries
/getEntry
no longer read files in folder on archives created with version >= 0.5.13
I'm not sure the version matches, but maybe it has something to do with the change on this commit (L.299)? It looks like a Windows fix has been removed but is not covered by the new code. |
we have the same problem, suddenly the entries that are created i guess on windows are give the \ in the path/name |
It is related with #497 and #512 and fixed in repo, but it is not released by @cthackers yet. |
It's released now! |
I just tested and this issue is solved with |
A bug was introduced on version
0.5.13
which affect reading files inside folders. I only tested the methodsgetEntries()
andreadFileAsync()
(which usesgetEntry()
), but I suppose this bug does not affect only these two. Here are some test cases:Whether I test on
v0.5.12
orv0.5.13
:For an archive created with
v0.5.12
getEntries()
-> returns root files + files in folder, withentryName
as:folder/file.jpg
getEntry()
-> works as expectedFor an archive created with
v0.5.13
getEntries()
-> returns root files + files in folder, withentryName
as:folder\\file.jpg
getEntry()
-> returns an error (viareadFileAsync()
):getEntry failed for:folder/file.jpg
Additionnaly, I can see that for both archives all the files and folders are here and with the correct names. Extracting all works as expected.
Something messing up the paths?
--
Versions:
The text was updated successfully, but these errors were encountered: