Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceError: totalEntries is not defined #526

Open
agustaf9 opened this issue Aug 6, 2024 · 2 comments
Open

ReferenceError: totalEntries is not defined #526

agustaf9 opened this issue Aug 6, 2024 · 2 comments

Comments

@agustaf9
Copy link

agustaf9 commented Aug 6, 2024

Error occurred in handler for 'writePacketFile': ReferenceError: totalEntries is not defined
    at Object.compressToBuffer (c:\Users\agustaf9\Downloads\test-app\node_modules\adm-zip\zipFile.js:297:13)
    at Object.writeZip (c:\Users\agustaf9\Downloads\test-app\node_modules\adm-zip\adm-zip.js:892:32)
    at Hu (c:\Users\agustaf9\Downloads\test-app\src\main\main.ts:115:7)
    at async WebContents.<anonymous> (node:electron/js2c/browser_init:2:83537) {stack: 'ReferenceError: totalEntries is not defined
 …us> (node:electron/js2c/browser_init:2:83537)', message: 'totalEntries is not defined'}

Looking at

totalEntries = 0;
the variable is never initialized

@agustaf9
Copy link
Author

agustaf9 commented Aug 6, 2024

This fixes my issue, not sure if something else was overlooked when the change was initially made though: #527

@ob1
Copy link

ob1 commented Aug 13, 2024

+1
Experiencing this too

wdzeng added a commit to wdzeng/firefox-addon that referenced this issue Aug 16, 2024
The `adm-zip` has some flaw so we cannot generate good JS files (see
cthackers/adm-zip#526). Therefore I do a
patch. We should remove the patch once the issue is fixed.
wdzeng added a commit to wdzeng/firefox-addon that referenced this issue Aug 16, 2024
The `adm-zip` has some flaw so we cannot generate good JS files (see
cthackers/adm-zip#526). Therefore I do a
patch. We should remove the patch once the issue is fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants