Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReferenceError: totalEntries is not defined. #534

Closed
sidartaveloso opened this issue Aug 16, 2024 · 2 comments · Fixed by #535
Closed

ReferenceError: totalEntries is not defined. #534

sidartaveloso opened this issue Aug 16, 2024 · 2 comments · Fixed by #535

Comments

@sidartaveloso
Copy link
Contributor

totalEntries was not declared, throwing error at this line.
to fix, I just put let at begin in this line.

let totalEntries = 0;

this situation was introced at this comit:

https://github.com/cthackers/adm-zip/blame/161a61f2283b96bbe692a7c5d232787636e8b3bc/zipFile.js#L259
sidartaveloso added a commit to devix-tecnologia/devix-adm-zip that referenced this issue Aug 16, 2024
@sidartaveloso
fix: totalEntries is not defined
7e31f27 
Update zipFile.js, declaring totalEntries variable using 'let' keyword.

resolv: cthackers#534
@sidartaveloso sidartaveloso mentioned this issue Aug 16, 2024
Merged
@olafurpg
Copy link

I am hitting on the same issue. I am unable to reproduce after downgrading to 0.5.10.

@riderx
Copy link

riderx commented Aug 27, 2024 •
edited
Loading

Same here, downgraded to 0.5.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: totalEntries is not defined devix-tecnologia/devix-adm-zip
3 participants
@sidartaveloso @olafurpg @riderx