Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display upcoming events under calendar #150

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

GAsplund
Copy link
Member

Key features

  • Display the next upcoming 3 events under the event calendar
  • Delete events if the parent news post is deleted

image

Known issues

  • I do not know any

@GAsplund GAsplund requested a review from simon-wg January 30, 2025 09:34
simon-wg
simon-wg previously approved these changes Jan 30, 2025
Copy link
Contributor

@simon-wg simon-wg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor note on a text stub which has no localization.
Also, we don't use ComingEvents anywhere, is this intended?

<p>
{i18nService.formatDate(event.startTime, true)}
{event.location && ', ' + event.location}{' '}
{ongoing && '(Ongoing)'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use localization for ongoing here

@GAsplund
Copy link
Member Author

Very much missed that I had it duplicated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants