Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some breaking changes from dependency #131

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Fix some breaking changes from dependency #131

merged 2 commits into from
Aug 25, 2023

Conversation

frqnck
Copy link
Contributor

@frqnck frqnck commented Aug 16, 2023 •
edited
Loading

firegento/fastsimpleimport >=2.0.0 has a diff API.

One commit, fix a method name change:

Call to undefined method FireGento\FastSimpleImport\Model\Importer::createImportModel()#0 /app/vendor/ctidigital/magento2-configurator/Component/Product/Validator.php(113): CtiDigital\Configurator\Component\Product\Validator->getImportRowFailures(Object(FireGento\FastSimpleImport\Model\Importer), Array)

The other a Typecasting error:

Return value of FireGento\FastSimpleImport\Model\Config::getImportFileDir() must be of the type string, null returned#0 /app/vendor/ctidigital/magento2-configurator/Component/Product/Image.php(210): FireGento\FastSimpleImport\Model\Config->getImportFileDir()

@paulpartington-cti paulpartington-cti merged commit a94d1fb into ctidigital:master Aug 25, 2023
@paulpartington-cti
Copy link
Contributor

@frqnck Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frqnck @paulpartington-cti