Skip to content

Commit

Permalink
fix: Update github workflow to prevent redis from overlapping ports. (f…
Browse files Browse the repository at this point in the history
…east-dev#2350)

* Update redis port

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* Add comment detailing why 12345 is port selected

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* Keep redis at 6379 for now until we can test against new github workflow

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
kevjumba authored Mar 2, 2022
1 parent 251eee4 commit c2a6c6c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/pr_integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ jobs:
# code from the PR.
ref: refs/pull/${{ github.event.pull_request.number }}/merge
submodules: recursive
- name: Start Redis
uses: supercharge/redis-github-action@1.4.0
with:
redis-version: ${{ matrix.redis-version }}
redis-port: 12345
- name: Setup Python
uses: actions/setup-python@v2
id: setup-python
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
)

DYNAMO_CONFIG = {"type": "dynamodb", "region": "us-west-2"}
# Port 12345 will chosen as default for redis node configuration because Redis Cluster is started off of nodes 6379 -> 6384. This causes conflicts in cli integration tests so we manually keep them separate.
REDIS_CONFIG = {"type": "redis", "connection_string": "localhost:6379,db=0"}
REDIS_CLUSTER_CONFIG = {
"type": "redis",
Expand Down

0 comments on commit c2a6c6c

Please sign in to comment.