Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-3120: populate commit and branch for manually triggered github actions #18

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

nitishkumar71
Copy link
Contributor

These changes will populate commit and branch information for manually triggered github actions too. Earlier, these informations were only being populated for event triggered actions

Signed-off-by: Nitishkumar Singh <nitish@cto.ai>
Signed-off-by: Nitishkumar Singh <nitish@cto.ai>
Signed-off-by: Nitishkumar Singh <nitish@cto.ai>
Signed-off-by: Nitishkumar Singh <nitish@cto.ai>
@nitishkumar71 nitishkumar71 marked this pull request as ready for review September 28, 2023 14:05
Copy link
Contributor

@NickAnderegg NickAnderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than one comment about where we should log an error message to make things easier to debug for users down the road.

src/run.js Outdated Show resolved Hide resolved
Signed-off-by: Nitishkumar Singh <nitish@cto.ai>
@nitishkumar71 nitishkumar71 merged commit fbd8d37 into main Oct 5, 2023
4 checks passed
@nitishkumar71 nitishkumar71 deleted the PROD-3120 branch October 5, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants