load :set_annotation_options before running :annotate_routes #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @javawizard, I'm not sure what |
|
For the time being, let's keep it as is, and we can remove it in a future release. |
drwl
approved these changes
May 18, 2020
javawizard
added a commit
to makesaltlake/heimdall
that referenced
this pull request
Sep 20, 2020
...now that ctran/annotate_models#803 has been merged. they still haven't cut a new release, though, so we need to target master instead of the vanilla gem.
ocarta-l
pushed a commit
to ocarta-l/annotate_models
that referenced
this pull request
Jun 18, 2021
Make `annotate_routes` depend on `set_annotation_options` just as `annotate_models` does. Fixes ctran#761.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
annotate_routesdepend onset_annotation_optionsjust asannotate_modelsdoes.Fixes #761.
I copied the
ENV['is_cli']check fromannotate_models.rake, but I don't know what its purpose is. Feel free to tell me to get rid of it. I also moved theannotate_lib = ...bit to the top of the file to keepannotate_routes.rakeconsistent withannotate_models.rake.