Skip to content

Commit

Permalink
Merge pull request #241 from squatched/fix-confluence-v2-get-space-types
Browse files Browse the repository at this point in the history
Fix Issue #240: Adjust SpaceSchemeV2 `id` & `homepageID` Types
  • Loading branch information
ctreminiom authored Sep 22, 2023
2 parents 297bc67 + c7a7787 commit 7ad0339
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion confluence/internal/space_v2_impl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
func Test_internalSpaceV2Impl_Bulk(t *testing.T) {

optionsMocked := &model.GetSpacesOptionSchemeV2{
IDs: []int{10001, 10002},
IDs: []string{"10001", "10002"},
Keys: []string{"DUMMY"},
Type: "global",
Status: "current",
Expand Down
6 changes: 3 additions & 3 deletions pkg/infra/models/confluence_space_v2.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ type SpacePageLinkSchemeV2 struct {
}

type GetSpacesOptionSchemeV2 struct {
IDs []int
IDs []string
Keys []string
Type string
Status string
Expand All @@ -23,12 +23,12 @@ type GetSpacesOptionSchemeV2 struct {
}

type SpaceSchemeV2 struct {
ID int `json:"id,omitempty"`
ID string `json:"id,omitempty"`
Key string `json:"key,omitempty"`
Name string `json:"name,omitempty"`
Type string `json:"type,omitempty"`
Status string `json:"status,omitempty"`
HomepageId int `json:"homepageId,omitempty"`
HomepageId string `json:"homepageId,omitempty"`
Description *SpaceDescriptionSchemeV2 `json:"description,omitempty"`
}

Expand Down

0 comments on commit 7ad0339

Please sign in to comment.