Added tests for parse request type & fixed test naming (#285)

ctreminiom · Jul 20, 2024 · acdd94c · acdd94c
1 parent a9d0768
commit acdd94c
Show file tree

Hide file tree

Showing 3 changed files with 598 additions and 63 deletions.
diff --git a/pkg/infra/models/errors.go b/pkg/infra/models/errors.go
@@ -161,6 +161,7 @@ var (
 	ErrNoCheckBoxTypeError                 = errors.New("custom-field: no check-box type set")
 	ErrNoCascadingParentError              = errors.New("custom-field: no cascading parent value set")
 	ErrNoCascadingChildError               = errors.New("custom-field: no cascading child value set")
+	ErrNoRequestTypeError                  = errors.New("custom-field: no request type value set")
 	ErrNoTempoAccountTypeError             = errors.New("custom-field: no tempo account value set")
 	ErrNoAttachmentIdsError                = errors.New("sm: no attachment id's set")
 	ErrNoLabelsError                       = errors.New("sm: no label names set")

diff --git a/pkg/infra/models/jira_issue_custom_fields.go b/pkg/infra/models/jira_issue_custom_fields.go
@@ -1855,12 +1855,12 @@ func ParseRequestTypeCustomField(buffer bytes.Buffer, customField string) (*Cust
 	// Check if the issue iteration contains information on the customfield selected,
 	// if not, continue
 	if raw.Get(path).Type == gjson.Null {
-		return nil, ErrNoAssetTypeError
+		return nil, ErrNoRequestTypeError
 	}
 
 	var requestType *CustomFieldRequestTypeScheme
 	if err := json.Unmarshal([]byte(raw.Get(path).String()), &requestType); err != nil {
-		return nil, ErrNoAssetTypeError
+		return nil, ErrNoRequestTypeError
 	}
 
 	return requestType, nil