Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📰 Implemented the first Confluence Cloud V2 services #183

Merged
merged 7 commits into from
Apr 3, 2023

Conversation

ctreminiom
Copy link
Owner

  1. Created a new interface called PageConnector.
  2. This interface will interacts with the Confluence Cloud V2 space endpoints.
  3. Mapped the page structures on the infra package
  4. Created the documentation links and associated them with the interface comments.

1. Created a new interface called PageConnector.
2. This interface will interacts with the Confluence Cloud V2 space endpoints.
3. Mapped the page structures on the infra package
4. Created the documentation links and associated them with the interface comments.
@ctreminiom ctreminiom added dependencies Pull requests that update a dependency file Confluence labels Apr 1, 2023
@ctreminiom ctreminiom self-assigned this Apr 1, 2023
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #183 (e329d37) into main (97f115d) will increase coverage by 0.11%.
The diff coverage is 90.86%.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   85.79%   85.91%   +0.11%     
==========================================
  Files         125      127       +2     
  Lines       10674    10883     +209     
==========================================
+ Hits         9158     9350     +192     
- Misses        857      865       +8     
- Partials      659      668       +9     
Impacted Files Coverage Δ
confluence/internal/page_impl.go 90.00% <90.00%> (ø)
confluence/v2/api_client_impl.go 92.20% <92.20%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1. Created the new implementation of the Page service.
2. Created more error templates
3. Changed the Page.Created() params to the centralized payload struct.
Created a new module under the Confluence package called V2.
1. Replaced the wrong endpoint concatenation to the correct pageID reference.
@ctreminiom ctreminiom merged commit fcb3966 into main Apr 3, 2023
@ctreminiom ctreminiom deleted the feature/confluence-v2-module-structure branch May 15, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confluence dependencies Pull requests that update a dependency file
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

1 participant