Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for textarea custom fields #253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sancyx
Copy link

@sancyx sancyx commented Jan 29, 2024

Add support for textarea custom fields.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 89.10%. Comparing base (06e675c) to head (075287d).
Report is 12 commits behind head on main.

Current head 075287d differs from pull request most recent head f8a1529

Please upload reports for the commit f8a1529 to get more accurate results.

Files Patch % Lines
pkg/infra/models/jira_customFields.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   88.89%   89.10%   +0.20%     
==========================================
  Files         154      154              
  Lines       12094    12037      -57     
==========================================
- Hits        10751    10725      -26     
+ Misses        701      670      -31     
  Partials      642      642              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctreminiom
Copy link
Owner

Hi @sancyx, thank you for investing your time in this project, could you please add the test cases for that method?, the CI is failing due the coverage.

Thanks!

@Fank
Copy link
Collaborator

Fank commented Jul 3, 2024

@ctreminiom if you merge this, I could add coverage for it.

@sancyx
Copy link
Author

sancyx commented Aug 23, 2024

Hi @ctreminiom, sorry I missed somehow the notifications about your comments.
I've added a test case, but I see there are merge conflicts, should I rebase my branch to main or some other branch?

@Fank
Copy link
Collaborator

Fank commented Aug 23, 2024

main is fine

pkg/infra/models/jira_custom_fields.go Dismissed Show dismissed Hide dismissed
@pragmaticivan
Copy link

hi @ctreminiom any chance you could get this in? Currently blocked on the V3 migration because of this missing function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

4 participants