Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ObjectTypeAttribute Payload for the creation and the update of the Assets Object Type Attribute #254

Merged
merged 16 commits into from
Mar 8, 2024

Conversation

tbaert-prest
Copy link
Contributor

Hello,

Like explain here : https://developer.atlassian.com/cloud/assets/rest/api-group-objecttypeattribute/#api-objecttypeattribute-objecttypeid-post, the type of the payload of the objecttypeattribute is not an ObjectTypeAttribute object.
In fact, for the creation of an attribute with the type 0 (default type), we need to fill the defaultTypeId parameter.
This parameter is missing in the objectTypeAttribute object.

@tbaert-prest
Copy link
Contributor Author

Correction of all issues done.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (73618c6) to head (d516aea).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files         154      154           
  Lines       12026    12026           
=======================================
  Hits        10725    10725           
  Misses        659      659           
  Partials      642      642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctreminiom ctreminiom added enhancement New feature or request Jira Assets labels Mar 8, 2024
@ctreminiom
Copy link
Owner

Hi @tbaert-prest thank you for your contribution, changes accepted 👍🏽

@ctreminiom ctreminiom merged commit 810da40 into ctreminiom:main Mar 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Jira Assets
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants