Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Upgraded the golang version to test/lint #294

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

ctreminiom
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.07%. Comparing base (06e675c) to head (721e383).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   88.89%   89.07%   +0.18%     
==========================================
  Files         154      156       +2     
  Lines       12094    12152      +58     
==========================================
+ Hits        10751    10825      +74     
+ Misses        701      679      -22     
- Partials      642      648       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fank
Copy link
Collaborator

Fank commented Jul 21, 2024

I quickly checked the 1.21 tests why they are failing and retried them, the code looks good to me.
I will check later with 1.21 why they are failing, maybe i can reproduce it.

@ctreminiom
Copy link
Owner Author

I quickly checked the 1.21 tests why they are failing and retried them, the code looks good to me. I will check later with 1.21 why they are failing, maybe i can reproduce it.

Yeah, the root cause it's because I used an old version of the linter to support the versions 1.17, 1.18, 1.19

@ctreminiom ctreminiom added the enhancement New feature or request label Jul 22, 2024
@ctreminiom ctreminiom merged commit 7290514 into main Jul 22, 2024
34 checks passed
@ctreminiom ctreminiom deleted the feature/ci-update branch July 22, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants