Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate Error in name #316

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Removed duplicate Error in name #316

merged 3 commits into from
Sep 16, 2024

Conversation

Fank
Copy link
Collaborator

@Fank Fank commented Aug 19, 2024

An Error is represented by the prefix Err, which means that an additional Error in the end is not needed.

ErrNoMemberIDError = errors.New("bitbucket: no member id set")
ErrNoWebhookIDError = errors.New("bitbucket: no webhook id set")
ErrNoRepositoryError = errors.New("bitbucket: no repository set")
ErrNoSCIMComplexValue = errors.New("admin: no scim complex value set")

Check warning

Code scanning / Revive (reported by Codacy)

exported var ErrNoSCIMComplexValue should have comment or be unexported Warning

exported var ErrNoSCIMComplexValue should have comment or be unexported
ErrNoCustomFieldID = errors.New("jira: no custom-field id set")
ErrNoWorkflowStatuses = errors.New("jira: no workflow statuses set")
ErrNoWorkflowScope = errors.New("jira: no workflow scope set")
ErrNoWorkflowStatusNameOrId = errors.New("jira: no workflow status name or id set")

Check warning

Code scanning / Revive (reported by Codacy)

var ErrNoWorkflowStatusNameOrId should be ErrNoWorkflowStatusNameOrID Warning

var ErrNoWorkflowStatusNameOrId should be ErrNoWorkflowStatusNameOrID
ErrNoFieldInformation = errors.New("custom-field: please provide a buffer with a valid fields object")
ErrNoMultiSelectType = errors.New("custom-field: no multiselect type found")
ErrNoAssetType = errors.New("custom-field: no asset type found")
ErrNoUrlType = errors.New("custom-field: no url type set")

Check warning

Code scanning / Revive (reported by Codacy)

var ErrNoUrlType should be ErrNoURLType Warning

var ErrNoUrlType should be ErrNoURLType
@Fank Fank marked this pull request as ready for review August 22, 2024 02:21
@Fank Fank requested a review from ctreminiom August 22, 2024 02:21
@ctreminiom ctreminiom merged commit 7989fbb into main Sep 16, 2024
27 checks passed
@ctreminiom ctreminiom deleted the fk_error_naming branch September 16, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants