Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed the Issue.Move() field injection #328

Merged
merged 1 commit into from
Oct 13, 2024
Merged

🐛 Fixed the Issue.Move() field injection #328

merged 1 commit into from
Oct 13, 2024

Conversation

ctreminiom
Copy link
Owner

@ctreminiom ctreminiom commented Oct 6, 2024

TODOS

  • Refactor the ADF move implementation
  • Increase the coverage

Root Cause 🔴

@breathingdust the transitionID field was not correctly injected during payload generation using the mergo library. This caused the following error:

2024/10/05 21:51:20 {"errorMessages":["Missing 'transition' identifier"],"errors":{}}

Additionally, when the ResolutionScheme was set in the struct, the fields ID, Name, and Description were being added incorrectly due to the absence of the omitempty tag.

Resolves #318

Screen Configuration.

  • Please make sure the Resolution field is added on the screen scheme configuration linked on the issuetype.

image

{
    "errorMessages": [],
    "errors": {
        "resolution": "Field 'resolution' cannot be set. It is not on the appropriate screen, or unknown."
    }
}
  • If the status transition is linked to a screen, the Resolution field must be included; otherwise, an error will occur.
  • Please ensure that the workflow transition's post-function overwrites the Resolution field when the issue transitions to Done or Resolved.

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.

Project coverage is 88.89%. Comparing base (5b6f46a) to head (05f2ad1).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
jira/internal/issue_impl_rich_text.go 41.17% 5 Missing and 5 partials ⚠️
pkg/infra/models/jira_issue_v2.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   88.88%   88.89%   +0.01%     
==========================================
  Files         158      158              
  Lines       12376    12335      -41     
==========================================
- Hits        11000    10965      -35     
+ Misses        724      722       -2     
+ Partials      652      648       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctreminiom ctreminiom marked this pull request as ready for review October 13, 2024 03:51
@ctreminiom ctreminiom merged commit 3fd17a6 into main Oct 13, 2024
26 checks passed
@ctreminiom ctreminiom deleted the bug/318 branch October 13, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant