Skip to content

[fips92] net/tipc: fix slab-use-after-free Read in tipc_aead_encrypt_done #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

[fips92] net/tipc: fix slab-use-after-free Read in tipc_aead_encrypt_done #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions net/tipc/crypto.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,12 +817,16 @@ static int tipc_aead_encrypt(struct tipc_aead *aead, struct sk_buff *skb,
goto exit;
}

/* Get net to avoid freed tipc_crypto when delete namespace */
get_net(aead->crypto->net);

/* Now, do encrypt */
rc = crypto_aead_encrypt(req);
if (rc == -EINPROGRESS || rc == -EBUSY)
return rc;

tipc_bearer_put(b);
put_net(aead->crypto->net);

exit:
kfree(ctx);
Expand Down Expand Up @@ -860,6 +864,7 @@ static void tipc_aead_encrypt_done(struct crypto_async_request *base, int err)
kfree(tx_ctx);
tipc_bearer_put(b);
tipc_aead_put(aead);
put_net(net);
}

/**
Expand Down