Add resolving state to component for multiple instances. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tance renders once the module is resolved. Fixes ctrlplusb#90
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 92.59% 92.85% +0.26%
==========================================
Files 3 3
Lines 81 84 +3
Branches 24 24
==========================================
+ Hits 75 78 +3
Misses 6 6
Continue to review full report at Codecov.
|
|
@ctrlplusb any change you can get this PR merged? we are blocked by this problem on 2.0 release |
|
hi any chance this might be merge? |
kronthto
added a commit
to kronthto/vi0lation.de
that referenced
this pull request
May 9, 2020
Use custom fixed build of async-component with ctrlplusb/react-async-component#93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushes the resolving state to each instance of a component.
Fixes #90