Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set guicursor if it's currently empty. #483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't set guicursor if it's currently empty. #483

wants to merge 1 commit into from

Conversation

kormat
Copy link

@kormat kormat commented Oct 5, 2018 •
edited
Loading

Fixes #404

This change is Reviewable

@mattn
Copy link
Member

mattn commented Oct 5, 2018 •
edited
Loading

TODO list

  • Windows gVim
  • Windows Vim
  • Linux gVim
  • Linux gnome-terminal
  • Linux xterm
  • MacVim carbon (NeedsHelp)
  • MacVim terminal (NeedsHelp)
  • Windows neovim (NeedsHelp)
  • Linux neovim (NeedsHelp)
  • MacVim neovim (NeedsHelp)

What this patch fixes?

@kormat
Copy link
Author

kormat commented Oct 5, 2018

The patch fixes linux neovim when using an older gnome-terminal (from ubuntu 16.04), both with tmux and without.

@mattn
Copy link
Member

mattn commented Oct 6, 2018

Thank you. I confirmed this don't break Windows vim/gvim. I'll look into this in later.

erbain pushed a commit to erbain/ctrlp.vim that referenced this pull request Dec 10, 2018
Patched with fix 483
c5a2c31 
ctrlpvim#483
@erbain erbain mentioned this pull request Dec 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kormat @mattn