Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scint amp and phi #9

Merged
merged 4 commits into from
Aug 9, 2024
Merged

fix: scint amp and phi #9

merged 4 commits into from
Aug 9, 2024

Conversation

tapyu
Copy link
Contributor

@tapyu tapyu commented Aug 6, 2024

closes #8

brianbreitsch
brianbreitsch approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@brianbreitsch brianbreitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes allocations on Scin_amp and Scin_phi to be the correct, smaller size nsamp_seg, rather than nfft, which only needs to be used for the Psi realization generation.

@brianbreitsch brianbreitsch merged commit f468206 into cu-sense-lab:master Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianbreitsch brianbreitsch brianbreitsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mismatch in the array dimension for the scintillation amplitude and phase
2 participants
@tapyu @brianbreitsch