Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-15: Implement Announcement Preview Popup #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

belle-hu
Copy link

Overview

Implement UI for tapping on an announcement within Active Announcements or Past Announcements and displaying a popup.

Changes Made

  • Revised how dateInRange is called within existing code (AnnouncementCell) because the LiveIndicator was not being displayed properly. I discovered the existing code was calling dateInRange with the arguments in the wrong order.
  • Uploaded a placeholder image for the user doing the scheduling of the announcement (lauren.png)
  • Modified page.tsx to revise the hardcoded data; added a new hardcoded Announcement object so that we had an upcoming announcement (because we didn't have any hardcoded announcements before). Revise the id numbers of the hardcoded data because there were two announcements with id 4.
  • Created a new icon CrossThinIcon to represent the close button of the popup
  • Implemented ModalLiveIndicator, ModalUpcomingIndicator, ModalPastIndicator. Implemented a new variant of the existing LiveIndicator because the existing one was statically programmed to be in a specific position. ModalLiveIndicator, ModalUpcomingIndicator, and ModalPastIndicator are all dynamically positioned.
  • Implemented ButtonPrimary2 for the "Delete Announcement" button
  • Implemented ButtonPrimary3 for the "End Live Announcement" button
  • I needed to implement ButtonPrimary2 and ButtonPrimary3 because the existing Primary1 and Secondary1 hardcode the caret icon.
  • Implemented AnnouncementModal.tsx to handle all the UI logic for the popup

Screenshots

Screenshot 2024-10-14 at 9 05 03 PM Screenshot 2024-10-14 at 9 05 18 PM Screenshot 2024-10-14 at 9 05 28 PM Screenshot 2024-10-14 at 9 05 45 PM Screenshot 2024-10-14 at 9 07 32 PM Screenshot 2024-10-14 at 9 07 44 PM

@vinnie4k vinnie4k added the enhancement New feature or request label Oct 17, 2024
@vinnie4k vinnie4k added this to the MVP Launch milestone Oct 17, 2024
@vinnie4k vinnie4k linked an issue Oct 17, 2024 that may be closed by this pull request
Copy link
Collaborator

@vinnie4k vinnie4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Just a couple changes to your grouping approach as well as CSS styling, but other than that, this is very solid.

I collapsed a few div elements in the image below, but overall it should be grouped like such:
image

Make sure that when you create a commit, please prepend WEB-15: to the commit message. For example, WEB-15: Fix div element grouping.

Very impressive work Belle!

src/components/landing/ActiveAnnouncements.tsx Outdated Show resolved Hide resolved
src/components/landing/ActiveAnnouncements.tsx Outdated Show resolved Hide resolved
src/components/landing/ActiveAnnouncements.tsx Outdated Show resolved Hide resolved
src/components/landing/AnnouncementCell.tsx Outdated Show resolved Hide resolved
src/components/landing/AnnouncementModal.tsx Outdated Show resolved Hide resolved
src/components/landing/AnnouncementModal.tsx Outdated Show resolved Hide resolved
src/components/landing/AnnouncementModal.tsx Outdated Show resolved Hide resolved
src/components/landing/AnnouncementModal.tsx Outdated Show resolved Hide resolved
src/components/landing/AnnouncementModal.tsx Outdated Show resolved Hide resolved
src/components/landing/PastAnnouncements.tsx Outdated Show resolved Hide resolved
- Also addressed PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WEB-15: Announcement preview
2 participants