Merge pull request #94 from cuappdev/ashley/fix-testing

fix: debugging getPostsByUserId and test suite
cuappdev · Nov 9, 2024 · c357e9d · c357e9d
2 parents 510499d + 975cb53
commit c357e9d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/src/services/PostService.ts b/src/services/PostService.ts
@@ -44,11 +44,9 @@ export class PostService {
 
   public async getPostsByUserId(currentUser: UserModel, params: UuidParam): Promise<PostModel[]> {
     return this.transactions.readOnly(async (transactionalEntityManager) => {
-      const userRepository = Repositories.user(transactionalEntityManager);
-      const user = await userRepository.getUserById(params.id)
-      if (!user) throw new NotFoundError('User not found!');
-      if (!user.isActive) throw new NotFoundError('User is not active!');
-      return this.filterBlockedUserPosts(user.posts, currentUser);
+      const postRepository = Repositories.post(transactionalEntityManager);
+      const userPosts = await postRepository.getPostsByUserId(params.id);
+      return this.filterBlockedUserPosts(userPosts, currentUser);
     });
   }
 

diff --git a/src/tests/PostTest.test.ts b/src/tests/PostTest.test.ts
@@ -104,14 +104,9 @@ describe('post tests', () => {
       .createUsers(post.user)
       .write();
 
-    expectedPost.user = post.user;
-
-    const getPostsResponse = await postController.getPostsByUserId(post.user, uuidParam);
+    const getPostsResponse = await postController.getPostsByUserId(post.user, {id: post.user.id});
     getPostsResponse.posts[0].original_price = Number(getPostsResponse.posts[0].original_price);
-    getPostsResponse.posts[0].altered_price = Number(getPostsResponse.posts[0].altered_price);
-    expectedPost.created = getPostsResponse.posts[0].created;
-
-    expect(getPostsResponse.posts).toEqual([expectedPost]);
+    expect(getPostsResponse.posts).toEqual([post]);
   });
 
   test('create post', async () => {