Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests #96

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Fixed tests #96

merged 1 commit into from
Nov 10, 2024

Conversation

Daniel-jw
Copy link
Contributor

Overview

Fixed 5 failing tests - 3 were requests and 2 soft delete

Changes Made

Ensured archive from request was updated in the tests and soft delete was querying the user id column correctly

Test Coverage

npm run test passes

Copy link

@Aayush-Agnihotri Aayush-Agnihotri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ashleynhs ashleynhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Daniel-jw Daniel-jw merged commit e57679c into main Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants