Implement UI components of Game Details Screen #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
helenjb
commented
Nov 20, 2024
•
helenjb
commented
- Create GameDetailsScreen.kt
- Implement GameScoreHeader.kt, TimeUntilStartCard.kt, and ButtonPrimary.kt
- Solely UI (no logic yet)
thisjustin123
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Great UI additions! I have a few tweaks for you for the components but once you change those you can feel free to merge.
As for the merge conflicts, you can resolve them by locally merging (the latest version of) main into your branch and going through whatever merge conflict resolver stuff you have to resolve, then pushing again.
app/src/main/java/com/cornellappdev/score/components/ButtonPrimary.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/GameScoreHeader.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/TimeUntilStartCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/screen/GameDetailsScreen.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.