Skip to content

chore(Form): stabilize behavior #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 22, 2022
Merged

chore(Form): stabilize behavior #112

merged 6 commits into from
Jun 22, 2022

Conversation

tenphi
Copy link
Member

@tenphi tenphi commented Jun 17, 2022

Form

  • Fixes rules update
  • Fixes onSubmit, onSubmitFailed, onValuesChange update
  • Clear error on external setFieldValue with different value

Other

  • TooltipProvider: change useEffect behavior to avoid loop (I don't know exactly why)
  • Update ReactAria/Select to avoid loop as well

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 27f8558

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tenphi tenphi requested a review from MrFlashAccount June 17, 2022 17:14
@tenphi tenphi temporarily deployed to Docs staging June 17, 2022 17:14 Inactive
@tenphi tenphi requested a review from nikolaykost June 17, 2022 17:14
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022 •
edited
Loading

🏋️ Size limit report

Name Size Passed?
All 196.85 KB (+20.95% 🔺) Yes 🎉
Tree shaking (just a Button) 31.72 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022 •
edited
Loading

📦 NPM canary release

Deployed canary version 0.0.0-canary-f940766.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022 •
edited
Loading

🏗 Docs are successfully deployed!

👀 Preview: https://62b2efbb75a7677362400bd1--cube-uikit-storybook.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022 •
edited
Loading

🧪 Storybook is successfully deployed!

@tenphi tenphi temporarily deployed to Docs staging June 20, 2022 08:51 Inactive
@tenphi tenphi temporarily deployed to Docs staging June 20, 2022 08:56 Inactive
nikolaykost
nikolaykost suggested changes Jun 20, 2022
View reviewed changes
MrFlashAccount
MrFlashAccount approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@MrFlashAccount MrFlashAccount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏋️

@tenphi tenphi temporarily deployed to Docs staging June 21, 2022 14:53 Inactive
@tenphi tenphi temporarily deployed to Docs staging June 22, 2022 09:36 Inactive
@tenphi tenphi temporarily deployed to Docs staging June 22, 2022 10:29 Inactive
@tenphi tenphi merged commit 7432820 into main Jun 22, 2022
@tenphi tenphi deleted the form-fixes branch June 22, 2022 10:53
@github-actions github-actions bot mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFlashAccount MrFlashAccount MrFlashAccount approved these changes

@nikolaykost nikolaykost nikolaykost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tenphi @MrFlashAccount @nikolaykost