Skip to content

fix(Field): respect onSelectionChange event of ComboBox #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tenphi
Copy link
Member

@tenphi tenphi commented Aug 15, 2022

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2022

🦋 Changeset detected

Latest commit: 5fc3c38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2022

🏗 Docs are successfully deployed!

👀 Preview: https://62fe7db3d194af005d6cba6b--cube-uikit-storybook.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2022

📦 NPM canary release

Deployed canary version 0.0.0-canary-97528b8.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2022

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2022

🏋️ Size limit report

Name Size Passed?
All 141.29 KB (+0.07% 🔺) Yes 🎉
Tree shaking (just a Button) 32.03 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

…fired-if-allows-custom-value-is-false-and-value-is-not-in-the-list
…fired-if-allows-custom-value-is-false-and-value-is-not-in-the-list
…fired-if-allows-custom-value-is-false-and-value-is-not-in-the-list
tenphi added 2 commits August 18, 2022 18:18
…fired-if-allows-custom-value-is-false-and-value-is-not-in-the-list
Copy link
Contributor

@nikolaykost nikolaykost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need some explanation, what cases this changes solves.
Also I have some suggestions above.

@tenphi tenphi merged commit 16a213a into main Aug 18, 2022
@tenphi tenphi deleted the CUK-123-combo-box-on-selection-change-event-fired-if-allows-custom-value-is-false-and-value-is-not-in-the-list branch August 18, 2022 18:02
@github-actions github-actions bot mentioned this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants