-
Notifications
You must be signed in to change notification settings - Fork 7
[CC-1327] Trigger onDismiss on Esc press #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 64e5819 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🧪 Storybook is successfully deployed!
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-90d1ee5. |
🏗 Docs are successfully deployed!👀 Preview: https://63354d871a19b463f71faa5d--cube-uikit-storybook.netlify.app |
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I would probably add more cases to cover resolve
callback and rejecting by the close button.
Describe changes
This PR fixes a bug when
onDismiss
didn't trigger onESC
press.Checklist
Before taking this PR from the draft, please, make sure you have done the following:
Closes: CC-1327
Other information