-
Notifications
You must be signed in to change notification settings - Fork 7
fix: transition import & SubmitError handling #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d781d47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🏗 Docs are successfully deployed!👀 Preview: https://63580e3a7886da1b938f6f16--cube-uikit-storybook.netlify.app |
📦 NPM canary releaseDeployed canary version 0.0.0-canary-d031b13. |
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
🧪 Storybook is successfully deployed!
|
all these cases could be easily covered with unit tests. Reach me in DM if you need some help |
@MrFlashAccount I wasn't able to create a test that checks an uncaught rejection. |
@tenphi feel free to reach me in DM anytime 😊 |
Fix Transition import
Submit error should follow the rules:
SubmitError
component should show the error only if it's a valid react element or a string. For other cases, it should show "Internal error" so we don't expose unhandled errors to the user.If Form submission is failed on the validation step, then the
onFailed
callback is not fired.