Skip to content

fix(Menu): custom properties bindings #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2022
Merged

fix(Menu): custom properties bindings #245

merged 2 commits into from
Nov 17, 2022

Conversation

tenphi
Copy link
Member

@tenphi tenphi commented Nov 16, 2022

Fixes error with direct onAction handler binding to the Menu root element. This handler shouldn't be bonded to the element itself.

@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2022

🦋 Changeset detected

Latest commit: 176c647

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

🏗 Docs are successfully deployed!

👀 Preview: https://6374d9ecd2c68803a1ab4b53--cube-uikit-storybook.netlify.app

@github-actions
Copy link
Contributor

📦 NPM canary release

Deployed canary version 0.0.0-canary-cb9b60b.

@github-actions
Copy link
Contributor

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

🏋️ Size limit report

Name Size Passed?
All 140.12 KB (+0.01% 🔺) Yes 🎉
Tree shaking (just a Button) 25.16 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@tenphi tenphi merged commit bd9d88f into main Nov 17, 2022
@tenphi tenphi deleted the fix-menu-props branch November 17, 2022 10:38
@github-actions github-actions bot mentioned this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants