Add hideOnClose flag in <DialogTrigger />
#274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9c2a7f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MrFlashAccount
changed the title
hideBehavior flag in <DialogTrigger />`hideBehavior flag in <DialogTrigger />
🏗 Docs are successfully deployed!👀 Preview: https://63db9101798b483132cc0b3a--cube-uikit-storybook.netlify.app |
📦 NPM canary releaseDeployed canary version 0.0.0-canary-54e1ed5. |
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
🧪 Storybook is successfully deployed!
|
tenphi
reviewed
Jan 18, 2023
MrFlashAccount
changed the title
hideBehavior flag in <DialogTrigger />hideOnClose flag in <DialogTrigger />
tenphi
reviewed
Feb 1, 2023
tenphi
approved these changes
Feb 1, 2023
tenphi
approved these changes
Feb 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
This PR add ability to specify the way how we'd like to hide a dialog: by unmounting or by hiding in css
Checklist
Before taking this PR from the draft, please, make sure you have done the following:
Closes: N/A
Other information