Skip to content

Add shouldCloseOnInteractOutside in <DialogTrigger /> #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Feb 8, 2023

Describe changes

Checklist

Before taking this PR from the draft, please, make sure you have done the following:

  • Pipeline is passed
  • Tests are added (including unit tests and stories in the storybook)
  • Tests are passed successfully
  • If you're adding a new component/new props, add stories that describe how this component/prop works
  • Changeset(s) is(are) added
  • You have passed the threshold of the library size
  • Commit message follows commit guidelines

Closes: N/A

Other information

Please refer the storybook for more information

@MrFlashAccount MrFlashAccount requested a review from tenphi February 8, 2023 18:14
@MrFlashAccount MrFlashAccount self-assigned this Feb 8, 2023
@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2023

🦋 Changeset detected

Latest commit: a66d3ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

🏗 Docs are successfully deployed!

👀 Preview: https://63e3e6ace48b300581caedcf--cube-uikit-storybook.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

📦 NPM canary release

Deployed canary version 0.0.0-canary-eab6b42.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

🏋️ Size limit report

Name Size Passed?
All 151.39 KB (+0.02% 🔺) Yes 🎉
Tree shaking (just a Button) 25.23 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@MrFlashAccount MrFlashAccount merged commit 842836f into main Feb 9, 2023
@MrFlashAccount MrFlashAccount deleted the add_ability_to_prevent_click_outside branch February 9, 2023 10:24
@github-actions github-actions bot mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants