Skip to content

Fix types in Combobox and fix filter function #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2023
Merged

Fix types in Combobox and fix filter function #336

merged 3 commits into from
Apr 26, 2023

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Apr 26, 2023 •
edited
Loading

Describe changes

Checklist

Before taking this PR from the draft, please, make sure you have done the following:

  • Pipeline is passed
  • Tests are added (including unit tests and stories in the storybook)
  • Tests are passed successfully
  • If you're adding a new component/new props, add stories that describe how this component/prop works
  • Changeset(s) is(are) added
  • You have passed the threshold of the library size
  • Commit message follows commit guidelines

Closes: N/A

Other information

@MrFlashAccount MrFlashAccount requested a review from tenphi April 26, 2023 11:13
@MrFlashAccount MrFlashAccount self-assigned this Apr 26, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: a44fd40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MrFlashAccount MrFlashAccount added the bug Something isn't working label Apr 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited
Loading

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited
Loading

🏗 Docs are successfully deployed!

👀 Preview: https://6449134f095124630bad6911--cube-uikit-storybook.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited
Loading

📦 NPM canary release

Deployed canary version 0.0.0-canary-e9e1c13.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited
Loading

🏋️ Size limit report

Name Size Passed?
All 149.56 KB (+0.15% 🔺) Yes 🎉
Tree shaking (just a Button) 26.37 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@MrFlashAccount MrFlashAccount enabled auto-merge (squash) April 26, 2023 11:19
@MrFlashAccount MrFlashAccount merged commit a6ce43d into main Apr 26, 2023
@MrFlashAccount MrFlashAccount deleted the bugfix/combobox-filter-issue branch April 26, 2023 12:08
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenphi tenphi tenphi approved these changes

Assignees

@MrFlashAccount MrFlashAccount

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrFlashAccount @tenphi