Skip to content

chore: improve compatibility with react 18 #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: improve compatibility with react 18 #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dry-penguins-drive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@cube-dev/ui-kit': minor
---

Improve compatibility with React 18 in some cases.
5 changes: 2 additions & 3 deletions src/tasty/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { AllHTMLAttributes, CSSProperties } from 'react';
import { AllHTMLAttributes, CSSProperties, PropsWithChildren } from 'react';

import { Styles } from './styles/types';
import {
Expand Down Expand Up @@ -80,8 +80,7 @@ export interface BasePropsWithoutChildren
}

export interface BaseProps
extends BasePropsWithoutChildren,
Pick<AllHTMLAttributes<HTMLElementTagNameMap['div']>, 'children'> {}
extends PropsWithChildren<BasePropsWithoutChildren> {}

export interface AllBaseProps<K extends keyof HTMLElementTagNameMap = 'div'>
extends BaseProps,
Expand Down