Skip to content

fix(Overlay): faster transitions #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-clouds-sleep.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@cube-dev/ui-kit': patch
---

Faster overlay transition with 120ms duration instead of 180ms.
5 changes: 5 additions & 0 deletions .changeset/strong-falcons-complain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cube-dev/ui-kit": patch
---

Minor fixes for typings.
111 changes: 0 additions & 111 deletions .eslintrc.js

This file was deleted.

6 changes: 3 additions & 3 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const setMessage = require('${{ github.workspace }}/scripts/ci/set-message')
const setMessage = require('${{ github.workspace }}/scripts/ci/set-message.cjs')

await setMessage({
header: "## :package: NPM canary release",
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const setMessage = require('${{ github.workspace }}/scripts/ci/set-message')
const setMessage = require('${{ github.workspace }}/scripts/ci/set-message.cjs')

await setMessage({
header: "## 🧪 Storybook is successfully deployed!",
Expand Down Expand Up @@ -224,7 +224,7 @@ jobs:
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const setMessage = require('${{ github.workspace }}/scripts/ci/set-message')
const setMessage = require('${{ github.workspace }}/scripts/ci/set-message.cjs')

await setMessage({
header: "## 🏗 Docs are successfully deployed!",
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/size-limit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: Measure size
id: measure_size
continue-on-error: true
run: BASELINE='./__compare/${{ env.REPORT_FOLDER }}/output.json' node ./scripts/ci/measure-size.mjs
run: BASELINE='./__compare/${{ env.REPORT_FOLDER }}/output.json' node ./scripts/ci/measure-size.js

- name: Save stats
run: echo '${{ steps.measure_size.outputs.result }}' > ./size-limit-report/output.json
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const setMessage = require('${{ github.workspace }}/scripts/ci/set-message')
const setMessage = require('${{ github.workspace }}/scripts/ci/set-message.cjs')

await setMessage({
header: "## 🏋️ Size limit report",
Expand Down
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,4 @@ stats.html
.eslintcache
yarn-error.log
coverage
size-limit-report
size-limit-report-compare
size-limit-report/stats.json
4 changes: 0 additions & 4 deletions .prettierrc

This file was deleted.

22 changes: 22 additions & 0 deletions .prettierrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
module.exports = {
singleQuote: true,
trailingComma: 'all',
importOrder: [
'^:node',
'<BUILTIN_MODULES>',
'',
'<THIRD_PARTY_MODULES>',
'',
'^[.]{2,}',
'',
'^[.]/(?!index)',
'',
'^[./]',
'',
'<TYPES>',
'<TYPES>^[.]{2,}',
'<TYPES>^[./]',
],
importOrderTypeScriptVersion: '5.0.0',
plugins: ['@ianvs/prettier-plugin-sort-imports'],
};
2 changes: 1 addition & 1 deletion .size-limit.js → .size-limit.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ module.exports = [
}),
);
},
limit: '243kB',
limit: '245kB',
},
{
name: 'Tree shaking (just a Button)',
Expand Down
3 changes: 3 additions & 0 deletions commitlint.config.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
extends: ['@commitlint/config-conventional'],
};
1 change: 0 additions & 1 deletion commitlint.config.js

This file was deleted.

Loading
Loading