Skip to content

CUK-72 Isolate tasty engine #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 13, 2022
Merged

CUK-72 Isolate tasty engine #84

merged 18 commits into from
May 13, 2022

Conversation

tenphi
Copy link
Member

@tenphi tenphi commented Apr 25, 2022

No description provided.

@tenphi tenphi temporarily deployed to Chromatic staging April 25, 2022 16:56 Inactive
@github-actions
Copy link
Contributor

📦 Deployed canary version 0.0.0-canary-8b12353.

@changeset-bot
Copy link

changeset-bot bot commented May 3, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: bdfca57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MrFlashAccount MrFlashAccount temporarily deployed to Chromatic staging May 3, 2022 21:38 Inactive
@MrFlashAccount MrFlashAccount temporarily deployed to Docs staging May 3, 2022 21:38 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022 •
edited
Loading

📦 NPM canary release

Deployed canary version 0.0.0-canary-4e595be.

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022 •
edited
Loading

🏋️ Size limit report

Name Size Time Passed?
All 177.76 KB 3.6 s 🎉
Tree shaking (just a Button) 25.29 KB 506 ms 🎉

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022 •
edited
Loading

🏗 Docs are successfully deployed!

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022 •
edited
Loading

🧪 Storybook is successfully deployed!

@cube-js cube-js deleted a comment from github-actions bot May 3, 2022
@tenphi tenphi temporarily deployed to Docs staging May 9, 2022 13:32 Inactive
@tenphi tenphi temporarily deployed to Chromatic staging May 9, 2022 13:32 Inactive
@tenphi tenphi temporarily deployed to Chromatic staging May 9, 2022 13:36 Inactive
@tenphi tenphi temporarily deployed to Docs staging May 9, 2022 13:36 Inactive
@tenphi tenphi temporarily deployed to Chromatic staging May 10, 2022 10:35 Inactive
@tenphi tenphi temporarily deployed to Docs staging May 10, 2022 10:35 Inactive
@tenphi tenphi temporarily deployed to Docs staging May 10, 2022 10:58 Inactive
@tenphi tenphi temporarily deployed to Chromatic staging May 10, 2022 10:58 Inactive
@tenphi tenphi temporarily deployed to Chromatic staging May 10, 2022 14:56 Inactive
@tenphi tenphi temporarily deployed to Docs staging May 10, 2022 14:56 Inactive
@tenphi tenphi temporarily deployed to Chromatic staging May 10, 2022 14:59 Inactive
@tenphi tenphi temporarily deployed to Docs staging May 10, 2022 14:59 Inactive
@tenphi tenphi requested a review from MrFlashAccount May 10, 2022 15:04
@tenphi tenphi temporarily deployed to Docs staging May 11, 2022 16:08 Inactive
@tenphi tenphi temporarily deployed to Chromatic staging May 11, 2022 16:08 Inactive
MrFlashAccount
MrFlashAccount suggested changes May 13, 2022
View reviewed changes
Copy link
Contributor

@MrFlashAccount MrFlashAccount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a great work, I found a few things that could make this PR even better

@tenphi tenphi temporarily deployed to Chromatic staging May 13, 2022 12:33 Inactive
@tenphi tenphi temporarily deployed to Docs staging May 13, 2022 12:33 Inactive
MrFlashAccount
MrFlashAccount approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@MrFlashAccount MrFlashAccount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tenphi tenphi merged commit 9af598c into main May 13, 2022
@tenphi tenphi deleted the isolate-tasty branch May 13, 2022 13:34
@github-actions github-actions bot mentioned this pull request May 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFlashAccount MrFlashAccount MrFlashAccount approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tenphi @MrFlashAccount