Skip to content

Commit

Permalink
feat(duckdb-driver): remove unnecessary installing and loading HttpFS…
Browse files Browse the repository at this point in the history
… extension (#8375)

* feat(duckdb-driver): Upgrade to DuckDB 1.0.0

* feat(duckdb-driver): remove installing and loading httpfs extension

httpfs installed by default and its auto loadable extension

---------

Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com>
  • Loading branch information
benyaminsalimi and KSDaemon authored Nov 22, 2024
1 parent 47e7897 commit 0aee4fc
Showing 1 changed file with 0 additions and 26 deletions.
26 changes: 0 additions & 26 deletions packages/cubejs-duckdb-driver/src/DuckDBDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,32 +81,6 @@ export class DuckDBDriver extends BaseDriver implements DriverInterface {
const defaultConnection = db.connect();
const execAsync: (sql: string, ...params: any[]) => Promise<void> = promisify(defaultConnection.exec).bind(defaultConnection) as any;

try {
await execAsync('INSTALL httpfs');
} catch (e) {
if (this.logger) {
console.error('DuckDB - error on httpfs installation', {
e
});
}

// DuckDB will lose connection_ref on connection on error, this will lead to broken connection object
throw e;
}

try {
await execAsync('LOAD httpfs');
} catch (e) {
if (this.logger) {
console.error('DuckDB - error on loading httpfs', {
e
});
}

// DuckDB will lose connection_ref on connection on error, this will lead to broken connection object
throw e;
}

const configuration = [
{
key: 's3_region',
Expand Down

0 comments on commit 0aee4fc

Please sign in to comment.