Skip to content

Commit

Permalink
chore(cubestore): Remove dependency on feature(cursor_remaining) in c…
Browse files Browse the repository at this point in the history
…ubehll (#8964)

This got removed in more recent versions of Rust.
  • Loading branch information
srh authored Nov 18, 2024
1 parent b75a37a commit 0dbc499
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion rust/cubestore/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ exclude this from your PR!)
```

[patch.'https://github.com/cube-js/arrow-rs']
arquet = { path = "../../../arrow-rs/parquet" }
parquet = { path = "../../../arrow-rs/parquet" }
arrow = { path = "../../../arrow-rs/arrow" }

[patch.'https://github.com/cube-js/arrow-datafusion']
Expand Down
2 changes: 1 addition & 1 deletion rust/cubestore/cubehll/src/instance.rs
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ impl HllInstance {
let mut values = Vec::with_capacity(num_hashes);
let mut data = Cursor::new(data);
let maxval = (1 << reg_width) as u32 - 1;
while !data.is_empty() {
while data.position() < data.get_ref().len() as u64 {
let hash = data.read_u64::<BigEndian>().unwrap();
let ind = hash & mask;
let val = hash >> log_num_buckets;
Expand Down
1 change: 0 additions & 1 deletion rust/cubestore/cubehll/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#![feature(cursor_remaining)]
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down

0 comments on commit 0dbc499

Please sign in to comment.