feat(cubestore): Build standalone aarch64-apple-darwin, thanks @vieira (

#8950) Fixes: #8949 --------- Co-authored-by: Dmitry Patsura <zaets28rus@gmail.com>
cube-js · Nov 13, 2024 · 737fb60 · 737fb60
1 parent 8e7c5c7
commit 737fb60
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 4 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -666,15 +666,16 @@ jobs:
         target:
           - x86_64-pc-windows-msvc
           - x86_64-apple-darwin
+          - aarch64-apple-darwin
         include:
           - target: x86_64-pc-windows-msvc
             os: windows-2019
             executable_name: cubestored.exe
             strip: true
             # cubestored.exe: CantPackException: superfluous data between sections
             compress: false
-            # Please use minimal possible version of macOS, because it produces constraint on libstdc++
             tar_executable: tar
+            # Please use minimal possible version of macOS, because it produces constraint on libstdc++
           - target: x86_64-apple-darwin
             os: macos-12
             executable_name: cubestored
@@ -683,6 +684,14 @@ jobs:
             compress: false
             # bsd tar has a different format with Sparse files which breaks download script
             tar_executable: gtar
+          - os: macos-14
+            target: aarch64-apple-darwin
+            executable_name: cubestored
+            # upx has been disabled because it is crashing for macOS Ventura or above! It was disabled on 2024-09-05.
+            strip: false
+            compress: false
+            # bsd tar has a different format with Sparse files which breaks download script
+            tar_executable: gtar
       fail-fast: false
     permissions:
       contents: write

diff --git a/.github/workflows/rust-cubestore-master.yml b/.github/workflows/rust-cubestore-master.yml
@@ -187,6 +187,7 @@ jobs:
         target:
           - x86_64-pc-windows-msvc
           - x86_64-apple-darwin
+          - aarch64-apple-darwin
         include:
           - os: windows-2019
             target: x86_64-pc-windows-msvc
@@ -201,6 +202,12 @@ jobs:
             # upx has been disabled because it is crashing for macOS Ventura or above! It was disabled on 2024-09-05.
             strip: false
             compress: false
+          - os: macos-14
+            target: aarch64-apple-darwin
+            executable_name: cubestored
+            # upx has been disabled because it is crashing for macOS Ventura or above! It was disabled on 2024-09-05.
+            strip: false
+            compress: false
       fail-fast: false
     steps:
       - uses: actions/checkout@v4

diff --git a/.github/workflows/rust-cubestore.yml b/.github/workflows/rust-cubestore.yml
@@ -118,6 +118,7 @@ jobs:
         target:
           - x86_64-pc-windows-msvc
           - x86_64-apple-darwin
+          - aarch64-apple-darwin
         include:
           - os: windows-2019
             target: x86_64-pc-windows-msvc
@@ -132,6 +133,12 @@ jobs:
             # upx has been disabled because it is crashing for macOS Ventura or above! It was disabled on 2024-09-05.
             strip: false
             compress: false
+          - os: macos-14
+            target: aarch64-apple-darwin
+            executable_name: cubestored
+            # upx has been disabled because it is crashing for macOS Ventura or above! It was disabled on 2024-09-05.
+            strip: false
+            compress: false
       fail-fast: false
     steps:
       - uses: actions/checkout@v4

diff --git a/rust/cubestore/js-wrapper/src/utils.ts b/rust/cubestore/js-wrapper/src/utils.ts
@@ -29,8 +29,7 @@ export function getTarget(): string {
             );
         }
       case 'darwin':
-        // Rosetta 2 is required
-        return 'x86_64-apple-darwin';
+        return 'aarch64-apple-darwin';
       default:
         throw new Error(
           `You are using ${process.env} platform on arm64 which is not supported by Cube Store`,
@@ -49,7 +48,6 @@ export function isCubeStoreSupported(): boolean {
   }
 
   if (process.arch === 'arm64') {
-    // We mark darwin as supported, but it uses Rosetta 2
     if (process.platform === 'darwin') {
       return true;
     }