Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snowflake-driver): Improve support for NUMERIC in pre-aggregations #2811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ovr
Copy link
Member

@ovr ovr commented May 24, 2021

Hello!

Thanks

@ovr ovr requested a review from a team as a code owner May 24, 2021 15:51
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Base: 56.92% // Head: 56.91% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (15e829f) compared to base (44f09c3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2811      +/-   ##
==========================================
- Coverage   56.92%   56.91%   -0.02%     
==========================================
  Files         115      115              
  Lines        8861     8863       +2     
  Branches     1931     1931              
==========================================
  Hits         5044     5044              
- Misses       3474     3476       +2     
  Partials      343      343              
Impacted Files Coverage Δ
...cubejs-query-orchestrator/src/driver/BaseDriver.js 26.06% <0.00%> (-0.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovr ovr force-pushed the snowflake-improve-support-decimal branch 2 times, most recently from 996b294 to 548aab7 Compare May 24, 2021 16:13
@ovr ovr force-pushed the snowflake-improve-support-decimal branch from 548aab7 to 15e829f Compare May 24, 2021 17:43
@paveltiunov paveltiunov requested a review from a team as a code owner November 5, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants