Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Ungrouped queries support #7056

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Aug 23, 2023

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#6750

@paveltiunov paveltiunov requested review from a team as code owners August 23, 2023 04:46
@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 5:02pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 5:02pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 5:02pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 5:02pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 5:02pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 5:02pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 5:02pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 5:02pm

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 96.23% and project coverage change: -15.29% ⚠️

Comparison is base (a01f910) 86.31% compared to head (0429fa6) 71.03%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7056       +/-   ##
===========================================
- Coverage   86.31%   71.03%   -15.29%     
===========================================
  Files         151      306      +155     
  Lines       31707    52601    +20894     
  Branches        0     5183     +5183     
===========================================
+ Hits        27368    37363     +9995     
- Misses       4339    14922    +10583     
- Partials        0      316      +316     
Flag Coverage Δ
cube-backend 47.15% <ø> (?)
cubesql 86.38% <96.23%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...sql/cubeclient/src/models/v1_load_request_query.rs 100.00% <ø> (ø)
rust/cubesql/cubesql/src/compile/builder.rs 0.00% <ø> (ø)
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 55.60% <ø> (ø)
rust/cubesql/cubesql/src/compile/rewrite/mod.rs 91.89% <ø> (ø)
...besql/cubesql/src/compile/rewrite/rules/filters.rs 94.63% <ø> (ø)
...cubesql/cubesql/src/compile/rewrite/rules/order.rs 98.46% <ø> (ø)
...besql/cubesql/src/compile/rewrite/rules/wrapper.rs 97.31% <ø> (ø)
...cubesql/cubesql/src/compile/test/rewrite_engine.rs 0.00% <0.00%> (ø)
rust/cubesql/cubesql/src/compile/mod.rs 93.28% <95.88%> (+0.07%) ⬆️
...t/cubesql/cubesql/src/compile/rewrite/converter.rs 89.89% <100.00%> (+0.03%) ⬆️
... and 3 more

... and 156 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit 1b5c161 into master Aug 23, 2023
44 checks passed
@paveltiunov paveltiunov deleted the sql-api-ungrouped branch August 23, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant