Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support multiple values in SET #7064

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR bumps cube-js/sqlparser-rs@b098e2d, adding support for setting several values in SET, comma-separated, e.g. SET a = b, c.
One case where this is problematic is SET search_path = public, other_schema with PostgreSQL. Such a query is issued, for instance, by DBeaver.
Related test is included.

@MazterQyou MazterQyou requested a review from a team as a code owner August 25, 2023 00:19
@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Aug 25, 2023 0:19am
examples-react-d3 ⬜️ Ignored (Inspect) Aug 25, 2023 0:19am
examples-react-dashboard ⬜️ Ignored (Inspect) Aug 25, 2023 0:19am
examples-react-data-table ⬜️ Ignored (Inspect) Aug 25, 2023 0:19am
examples-react-highcharts ⬜️ Ignored (Inspect) Aug 25, 2023 0:19am
examples-react-material-ui ⬜️ Ignored (Inspect) Aug 25, 2023 0:19am
examples-react-pivot-table ⬜️ Ignored (Inspect) Aug 25, 2023 0:19am
examples-vue-query-builder ⬜️ Ignored (Inspect) Aug 25, 2023 0:19am

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: -15.36% ⚠️

Comparison is base (cc28cd1) 86.37% compared to head (fea6807) 71.02%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7064       +/-   ##
===========================================
- Coverage   86.37%   71.02%   -15.36%     
===========================================
  Files         151      306      +155     
  Lines       32012    52608    +20596     
  Branches        0     5183     +5183     
===========================================
+ Hits        27651    37364     +9713     
- Misses       4361    14928    +10567     
- Partials        0      316      +316     
Flag Coverage Δ
cube-backend 47.15% <ø> (?)
cubesql 86.37% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
rust/cubesql/cubesql/e2e/tests/postgres.rs 80.03% <71.42%> (-0.12%) ⬇️

... and 157 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou merged commit 41af344 into master Aug 25, 2023
@MazterQyou MazterQyou deleted the cubesql/set-multiple-values branch August 25, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant