fix(cubesql): Allow CAST to be used with reaggregation
#7072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7072 +/- ##
===========================================
+ Coverage 47.15% 71.04% +23.88%
===========================================
Files 155 306 +151
Lines 20589 52632 +32043
Branches 5183 5183
===========================================
+ Hits 9709 37392 +27683
- Misses 10564 14924 +4360
Partials 316 316
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
MazterQyou
force-pushed
the
cubesql/holistics-timestamp-query
branch
from
6ab8ee4 to
65bca99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR fixes two issues with queries generated by Holistics.
The first issue is inability to use
CASTwith reaggregation. This would lead to expressions likeTO_CHAR(CAST ( "public_orders"."completedAt" AS timestamptz ), 'YYYY-MM-DD HH24:MI:SS.US')erroring out ifGROUP BYisn't in the query. Such expressions are now issued by Holistics fortimestamp-type columns. This is now fixed.The second issue is minor and is about formatting with
TO_CHAR. Previously.USwould implyup to microsecondsbut if the precision wasn't high enough (for example, .000000), the decimal part could have been cut in length or be entirely missing. This was inconsistent with PostgreSQL and is now resolved;.USwill always convert to six decimal digits.Related tests are included.