refactor(cubesql): Remove Extension from LogicalPlanLanguage::CubeScan #8775
+468
−530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8775 +/- ##
==========================================
- Coverage 82.69% 82.68% -0.01%
==========================================
Files 221 221
Lines 78467 78416 -51
==========================================
- Hits 64888 64842 -46
+ Misses 13579 13574 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcheshkov
force-pushed
the
remove-extension-wrap-cubescan
branch
from
d9b07d9
to
499510b
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
mcheshkov
force-pushed
the
remove-extension-wrap-cubescan
branch
2 times, most recently
from
3103c04
to
b0bb852
Compare
mcheshkov
force-pushed
the
remove-extension-wrap-cubescan
branch
3 times, most recently
from
567b067
to
3c3403b
Compare
mcheshkov
force-pushed
the
remove-extension-wrap-cubescan
branch
3 times, most recently
from
db67c9b
to
29cd43b
Compare
mcheshkov
force-pushed
the
remove-extension-wrap-cubescan
branch
from
29cd43b
to
527a147
Compare
Extensions is used meaningfully only for CubeScan, but not for CubeScanWrapper. Both are first-class logical plan nodes for us, so Extension is not helpful in egraph
mcheshkov
force-pushed
the
remove-extension-wrap-cubescan
branch
from
527a147
to
6e5d841
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Extensions is used meaningfully only for CubeScan, but not for CubeScanWrapper. Both are first-class logical plan nodes for us, so Extension is not helpful in egraph